tustvold commented on code in PR #2528:
URL: https://github.com/apache/arrow-rs/pull/2528#discussion_r952473706
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -836,24 +833,41 @@ mod tests {
#[test]
fn test_fixed_length_binary_column_reader() {
- let converter = FixedSizeArrayConverter::new(20);
run_single_column_reader_tests::<FixedLenByteArrayType, _,
RandFixedLenGen>(
20,
ConvertedType::NONE,
None,
- |vals| Arc::new(converter.convert(vals.to_vec()).unwrap()),
+ |vals| {
+ let mut builder =
FixedSizeBinaryBuilder::with_capacity(vals.len(), 20);
Review Comment:
We need to use the builder so that we can specify the length, otherwise
empty pages result in errors
https://github.com/apache/arrow-rs/runs/7969684590?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
