tustvold commented on code in PR #2528:
URL: https://github.com/apache/arrow-rs/pull/2528#discussion_r954610985
##########
parquet/src/arrow/record_reader/mod.rs:
##########
@@ -78,13 +78,23 @@ where
{
/// Create a new [`GenericRecordReader`]
pub fn new(desc: ColumnDescPtr) -> Self {
+ Self::new_with_records(desc, V::default())
+ }
+}
+
+impl<V, CV> GenericRecordReader<V, CV>
+where
+ V: ValuesBuffer,
+ CV: ColumnValueDecoder<Slice = V::Slice>,
+{
+ pub fn new_with_records(desc: ColumnDescPtr, records: V) -> Self {
Review Comment:
RecordReader itself is crate private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
