pitrou commented on code in PR #13804:
URL: https://github.com/apache/arrow/pull/13804#discussion_r952704967
##########
cpp/src/arrow/dataset/dataset.cc:
##########
@@ -16,13 +16,15 @@
// under the License.
#include "arrow/dataset/dataset.h"
+#include <arrow/util/thread_pool.h>
Review Comment:
Let's be careful to use the same inclusion style - quotes for Arrow
includes, brackets for other ones.
##########
cpp/src/arrow/dataset/dataset.h:
##########
@@ -174,9 +186,24 @@ class ARROW_DS_EXPORT Dataset : public
std::enable_shared_from_this<Dataset> {
Dataset(std::shared_ptr<Schema> schema, compute::Expression
partition_expression);
virtual Result<FragmentIterator> GetFragmentsImpl(compute::Expression
predicate) = 0;
+ virtual Result<FragmentGenerator> GetFragmentsAsyncImpl(compute::Expression
predicate);
std::shared_ptr<Schema> schema_;
compute::Expression partition_expression_ = compute::literal(true);
+
+ private:
Review Comment:
If it's private this means it will not be able to be called by a derived
class' `GetFragmentsAsyncImpl`? I'm not sure I understand the respective
responsibilities of `GetFragmentsAsyncImpl` vs `GetFragmentsAsyncImplBase`
here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
