pitrou commented on code in PR #13804:
URL: https://github.com/apache/arrow/pull/13804#discussion_r953408867
##########
cpp/src/arrow/dataset/dataset.h:
##########
@@ -174,9 +186,24 @@ class ARROW_DS_EXPORT Dataset : public
std::enable_shared_from_this<Dataset> {
Dataset(std::shared_ptr<Schema> schema, compute::Expression
partition_expression);
virtual Result<FragmentIterator> GetFragmentsImpl(compute::Expression
predicate) = 0;
+ virtual Result<FragmentGenerator> GetFragmentsAsyncImpl(compute::Expression
predicate);
std::shared_ptr<Schema> schema_;
compute::Expression partition_expression_ = compute::literal(true);
+
+ private:
Review Comment:
I think it's ok to add an `Executor*` argument to `GetFragmentsAsyncImpl`.
It doesn't need to have a default value, and that sounds better than having 3
methods for the same functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
