drin commented on code in PR #13932:
URL: https://github.com/apache/arrow/pull/13932#discussion_r953018682
##########
cpp/src/arrow/filesystem/localfs_benchmark.cc:
##########
@@ -66,7 +66,7 @@ class LocalFSFixture : public benchmark::Fixture {
arrow::internal::PlatformFilename
cur_root_dir) {
ASSERT_OK(arrow::internal::CreateDir(cur_root_dir));
- arrow::internal::StringFormatter<Int32Type> format;
+ arrow::internal::StringFormatter<DoubleType> format;
Review Comment:
I followed this up with a couple commits to do the following:
1. I changed to Int64Type for completeness, although, I didn't accommodate
the cast as recommended.
2. I removed the formatter altogether and the dependency on `formatting.h`
@pitrou I know you recommended using a stringstream, but I realized only 1
append was being done and the string was never re-used, so I just used
`operator+` overload and created a string instance directly. I'm not sure if
explicitly calling the constructor was necessary, but the aesthetics felt right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
