drin commented on code in PR #13932:
URL: https://github.com/apache/arrow/pull/13932#discussion_r953022624
##########
cpp/src/arrow/filesystem/localfs_benchmark.cc:
##########
@@ -66,7 +66,7 @@ class LocalFSFixture : public benchmark::Fixture {
arrow::internal::PlatformFilename
cur_root_dir) {
ASSERT_OK(arrow::internal::CreateDir(cur_root_dir));
- arrow::internal::StringFormatter<Int32Type> format;
+ arrow::internal::StringFormatter<DoubleType> format;
Review Comment:
also, @ManManson , thanks for the comment!
I verified the benchmarks don't really change (expected from @pitrou 's
comment about it being benchmark setup code). Really, there are only 1-4
iterations for each benchmark, so the variance is really high anyways (~10%).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
