yahoNanJing commented on code in PR #153:
URL: https://github.com/apache/arrow-ballista/pull/153#discussion_r954424909
##########
ballista/rust/scheduler/src/scheduler_server/grpc.rs:
##########
@@ -514,16 +514,15 @@ mod test {
#[tokio::test]
async fn test_poll_work() -> Result<(), BallistaError> {
let state_storage = Arc::new(StandaloneClient::try_new_temporary()?);
- let namespace = "default";
let scheduler: SchedulerServer<LogicalPlanNode, PhysicalPlanNode> =
SchedulerServer::new(
+ "localhost:50050".to_owned(),
state_storage.clone(),
- namespace.to_owned(),
BallistaCodec::default(),
);
let exec_meta = ExecutorRegistration {
id: "abc".to_owned(),
- optional_host:
Some(OptionalHost::Host("http://host:8080".to_owned())),
+ optional_host:
Some(OptionalHost::Host("http://localhost:8080".to_owned())),
Review Comment:
Thanks for your suggestion. Agree that `127.0.0.1` is much safer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
