yahoNanJing commented on code in PR #153:
URL: https://github.com/apache/arrow-ballista/pull/153#discussion_r954429206
##########
ballista/rust/scheduler/src/state/execution_graph.rs:
##########
@@ -175,145 +154,226 @@ impl ExecutionGraph {
/// An ExecutionGraph is complete if all its stages are complete
pub fn complete(&self) -> bool {
- self.stages.values().all(|s| s.complete())
+ self.stages
+ .values()
+ .all(|s| matches!(s, ExecutionStage::Completed(_)))
+ }
+
+ /// Revive the execution graph by converting the resolved stages to
running changes
+ /// If existing such change, return true; else false.
Review Comment:
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
