tustvold commented on code in PR #2585:
URL: https://github.com/apache/arrow-rs/pull/2585#discussion_r954547944
##########
arrow/src/compute/kernels/aggregate.rs:
##########
@@ -215,6 +215,68 @@ where
}
}
+/// Returns the min of values in the array.
+pub fn min_dyn<T, A: ArrayAccessor<Item = T::Native>>(array: A) ->
Option<T::Native>
Review Comment:
I wonder if we can't just have a single `min` kernel for all types? We
currently have separate implementations for strings, primitives, etc... which
is no longer needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
