viirya commented on code in PR #2585:
URL: https://github.com/apache/arrow-rs/pull/2585#discussion_r954556828
##########
arrow/src/compute/kernels/aggregate.rs:
##########
@@ -215,6 +215,68 @@ where
}
}
+/// Returns the min of values in the array.
+pub fn min_dyn<T, A: ArrayAccessor<Item = T::Native>>(array: A) ->
Option<T::Native>
Review Comment:
I guess that we have separate `min` for different type of arrays because
there was no common accessor previously.
But the `min` for primitive array, it has simd and non simd versions. I'm
hesitant to replace them with this `ArrayAccessor` version. Do you think it is
okay?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
