rtpsw commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r954579179
##########
cpp/src/arrow/compute/light_array.cc:
##########
@@ -141,6 +141,12 @@ Result<KeyColumnArray> ColumnArrayFromArrayData(
const std::shared_ptr<ArrayData>& array_data, int64_t start_row, int64_t
num_rows) {
ARROW_ASSIGN_OR_RAISE(KeyColumnMetadata metadata,
ColumnMetadataFromDataType(array_data->type));
+ return ColumnArrayFromArrayDataAndMetadata(array_data, metadata, start_row,
num_rows);
+}
+
+KeyColumnArray ColumnArrayFromArrayDataAndMetadata(
+ const std::shared_ptr<ArrayData>& array_data, const KeyColumnMetadata&
metadata,
+ int64_t start_row, int64_t num_rows) {
Review Comment:
Correct. See [this
usage](https://github.com/apache/arrow/pull/13880/files#diff-5789a42aebc3bd0f5a6db687c78ab0c3eef3e316982f99fe9e0ea21fabed354cR218).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
