rtpsw commented on code in PR #13880:
URL: https://github.com/apache/arrow/pull/13880#discussion_r954646530
##########
cpp/src/arrow/compute/exec/asof_join_node.cc:
##########
@@ -602,52 +828,155 @@ class AsofJoinNode : public ExecNode {
public:
AsofJoinNode(ExecPlan* plan, NodeVector inputs, std::vector<std::string>
input_labels,
- const AsofJoinNodeOptions& join_options,
+ const vec_col_index_t& indices_of_on_key,
+ const std::vector<vec_col_index_t>& indices_of_by_key, OnType
tolerance,
std::shared_ptr<Schema> output_schema);
+ Status InternalInit(bool must_hash, bool nullable_by_key,
Review Comment:
I needed an initialization method that returns `Status` in order to deal
with status-errors correctly, which cannot be done in a constructor. I tried
the name `Init` but that resulted in a compile error due to a conflict with an
`Init` method in a super-class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
