tustvold commented on code in PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#discussion_r955011191


##########
object_store/src/client/mod.rs:
##########
@@ -18,8 +18,6 @@
 //! Generic utilities reqwest based ObjectStore implementations
 
 pub mod backoff;
-#[cfg(any(feature = "gcp", feature = "azure"))]
-pub mod oauth;

Review Comment:
   The original hope of this module was that it would allow sharing code 
between the implementations, it transpires this isn't actually possible, so we 
might as well just split the module apart and avoid having to feature flag 
various things



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to