roeap commented on code in PR #2590:
URL: https://github.com/apache/arrow-rs/pull/2590#discussion_r956576932
##########
object_store/src/client/mod.rs:
##########
@@ -18,8 +18,6 @@
//! Generic utilities reqwest based ObjectStore implementations
pub mod backoff;
-#[cfg(any(feature = "gcp", feature = "azure"))]
-pub mod oauth;
Review Comment:
makes absolute sense. I have not yet lost all hope, as we may be able to
share for equivalent auth methods. I.e. I am hoping to add certificate based
auth as in gcp, as well as managed / workload identity that should be similar
to what aws is doing with the ec2 instance like stuff. But we'll see how that
works out.
##########
object_store/src/azure/credential.rs:
##########
@@ -38,6 +43,18 @@ pub(crate) static DELETE_SNAPSHOTS: HeaderName =
pub(crate) static COPY_SOURCE: HeaderName =
HeaderName::from_static("x-ms-copy-source");
static CONTENT_MD5: HeaderName = HeaderName::from_static("content-md5");
pub(crate) static RFC1123_FMT: &str = "%a, %d %h %Y %T GMT";
+const CONTENT_TYPE_JSON: &str = "application/json";
+
+#[derive(Debug, Snafu)]
+pub enum Error {
Review Comment:
More of a general question, since recently I have been wondering what errors
should look like. Thus far I very much like the approach taken in object_store,
having very specific errors internal to the modules, and surfacing it all in a
single error type to the user. Users might still work with this local error via
downcasting the genric type in the Generic folder, but i was wondering if the
approach should be to make al interna errors private to the crate, and have top
level variants, for everything we think the consumer might handle specifically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
