marsupialtail commented on code in PR #13830:
URL: https://github.com/apache/arrow/pull/13830#discussion_r955345360
##########
cpp/src/arrow/dataset/file_csv.cc:
##########
@@ -177,20 +177,15 @@ static inline Result<csv::ReadOptions> GetReadOptions(
}
static inline Future<std::shared_ptr<csv::StreamingReader>> OpenReaderAsync(
- const FileSource& source, const CsvFileFormat& format,
- const std::shared_ptr<ScanOptions>& scan_options, Executor* cpu_executor) {
+ const std::shared_ptr<io::BufferedInputStream>& input, const std::string&
path,
Review Comment:
This is private interface, and we know the input is BufferedInputStream, no
reason to support polymorphism here I think.
##########
cpp/src/arrow/dataset/file_base.h:
##########
@@ -211,8 +221,12 @@ class ARROW_DS_EXPORT FileFragment : public Fragment,
FileSource source_;
std::shared_ptr<FileFormat> format_;
-
friend class FileFormat;
+
+ // we do not want ParquetFileFragment to inherit these things.
+ private:
+ int64_t start_byte_ = 0;
+ int64_t end_byte_ = 0;
Review Comment:
Will use util::optional<ReadRange>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
