marsupialtail commented on code in PR #13830: URL: https://github.com/apache/arrow/pull/13830#discussion_r955346963
########## cpp/src/arrow/dataset/file_base.h: ########## @@ -211,8 +221,12 @@ class ARROW_DS_EXPORT FileFragment : public Fragment, FileSource source_; std::shared_ptr<FileFormat> format_; - friend class FileFormat; + + // we do not want ParquetFileFragment to inherit these things. Review Comment: Yeah.... This probably will change anyways. The thing I am going to do after this one gets merged is to incorporate @zhztheplayer's parquet slicing using this API -- so perhaps we do expect inheritance. And it's fine I think if FileFormats who currently don't support slicing get those attributes as long as they are private and can't be accessed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
