andygrove commented on code in PR #3222:
URL: https://github.com/apache/arrow-datafusion/pull/3222#discussion_r957705101


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1377,6 +1378,8 @@ impl SessionState {
         }
         rules.push(Arc::new(ReduceOuterJoin::new()));
         rules.push(Arc::new(FilterPushDown::new()));
+        // we do type coercion after filter push down so that we don't push 
CAST filters to Parquet

Review Comment:
   I filed https://github.com/apache/arrow-datafusion/issues/3289 applying 
`TypeCoercion` before `FilterPushDown`. I think the PR would get too large to 
review if I make those changes here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to