andygrove commented on code in PR #3222:
URL: https://github.com/apache/arrow-datafusion/pull/3222#discussion_r962184987
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -259,6 +260,23 @@ pub fn cast(expr: Expr, data_type: DataType) -> Expr {
}
}
+/// Create a cast expression
Review Comment:
I have now remove this function
##########
datafusion/core/tests/sql/aggregates.rs:
##########
@@ -1815,11 +1815,11 @@ async fn aggregate_avg_add() -> Result<()> {
assert_eq!(results.len(), 1);
let expected = vec![
-
"+--------------+----------------------------+----------------------------+----------------------------+",
- "| AVG(test.c1) | AVG(test.c1) Plus Int64(1) | AVG(test.c1) Plus
Int64(2) | Int64(1) Plus AVG(test.c1) |",
-
"+--------------+----------------------------+----------------------------+----------------------------+",
- "| 1.5 | 2.5 | 3.5
| 2.5 |",
-
"+--------------+----------------------------+----------------------------+----------------------------+",
+
"+--------------+---------------------------------------------+---------------------------------------------+---------------------------------------------+",
+ "| AVG(test.c1) | AVG(test.c1) Plus CAST(Int64(1) AS Float64) |
AVG(test.c1) Plus CAST(Int64(2) AS Float64) | CAST(Int64(1) AS Float64) Plus
AVG(test.c1) |",
Review Comment:
This is now fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
