tustvold commented on code in PR #2640:
URL: https://github.com/apache/arrow-rs/pull/2640#discussion_r962204473
##########
arrow/src/array/cast.rs:
##########
@@ -225,6 +225,255 @@ macro_rules! downcast_primitive_array {
$($p => $fallback,)*
}
};
+
+ (($values1:ident, $values2:ident) => $e:block $($p:pat => $fallback:expr
$(,)*)*) => {
Review Comment:
> suggested one will
Yeah, you will still need to check the type, it is what it is
> doesn't constrain the type
That's why i suggested using the generic kernel not math_op directly 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
