viirya commented on code in PR #2640:
URL: https://github.com/apache/arrow-rs/pull/2640#discussion_r962205557
##########
arrow/src/array/cast.rs:
##########
@@ -225,6 +225,255 @@ macro_rules! downcast_primitive_array {
$($p => $fallback,)*
}
};
+
+ (($values1:ident, $values2:ident) => $e:block $($p:pat => $fallback:expr
$(,)*)*) => {
Review Comment:
Oh oh right. 😄
Good news is it works.
But as `Float16Type` doesn't implement `ArrowNumericType`, I need to remove
`Float16Type` pattern from `downcast_primitive_array!` to make it work.
For `simd` feature, seems f16 related APIs are not available so it appears
not easy to let `Float16Type` implement `ArrowNumericType`.
Currently I leave single argument `downcast_primitive_array!` untouched and
stick with two argument one and make it constrain the two arguments must be
same type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
