thinkharderdev commented on code in PR #184:
URL: https://github.com/apache/arrow-ballista/pull/184#discussion_r962344872
##########
ballista/rust/scheduler/src/state/execution_graph.rs:
##########
@@ -485,8 +490,139 @@ impl ExecutionGraph {
self.output_locations.clone()
}
+ /// Reset running and completed stages on a given executor
Review Comment:
Sorry I missed those (it's a rather large PR :)). I think it might be worth
adding some coverage for different graph topologies though
(union/aggregation/coalesce).
This may be a bit more involved but it may also be worthwhile to test the
end-to-end flow from the grpc endpoint. There are quite a few moving parts here
and given this is an exceptional situation it will be hard to track down issues
that pop up in production.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
