thinkharderdev commented on code in PR #184:
URL: https://github.com/apache/arrow-ballista/pull/184#discussion_r962751050
##########
ballista/rust/scheduler/src/state/execution_graph.rs:
##########
@@ -581,6 +726,54 @@ impl ExecutionGraph {
}
}
+ /// Convert running stage to be unresolved
+ fn rollback_running_stage(&mut self, stage_id: usize) -> Result<bool> {
Review Comment:
> We can have the expiration time longer than the executor's heartbeat time
interval, so only after missing two or three consecutive heartbeats, the
Scheduler consider it is dead.
I think this is a good idea. We probably want to be pretty conservative in
marking an executor dead due to missing heartbeats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
