alamb commented on issue #2647: URL: https://github.com/apache/arrow-rs/issues/2647#issuecomment-1236834847
Ideally, I would expect the division kernel to have the same option as the cast kernel: 1. if [CastOptions::safe](https://docs.rs/arrow/21.0.0/arrow/compute/kernels/cast/struct.CastOptions.html) is true, then any indexes that divide by 0 would have their validity slot set to NULL and can have an arbitrary value in the values Buffer 2. If [CastOptions::safe](https://docs.rs/arrow/21.0.0/arrow/compute/kernels/cast/struct.CastOptions.html) is false, then if any indexes divide by zero, an `Err` is returned I believe this is consistent with what @liukun4515 and @viirya are saying I also *think* this is consistent with @tustvold 's proposal, but I am 100% sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
