tustvold commented on issue #2647: URL: https://github.com/apache/arrow-rs/issues/2647#issuecomment-1236841921
It isn't what I was proposing but having thought about it a bit more I'm not sure having checked and unchecked variants of the division kernel really makes sense: * Integer division is incredibly slow outweighing benefits of handling the null mask separately * There doesn't appear to be a way to get LLVM to vectorise it correctly (as the branch is always present) As such I would like to propose we only provide a single `division` and `modulus` kernels, which will return an error on division by zero. > there is no CastOption for division There is no CastOption for any of the arithmetic kernels, and I'm somewhat inclined to keep it that way. If people want the "safe" semantic (a name I really dislike) a preceding nullif will likely perform similarly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
