liukun4515 commented on code in PR #3370:
URL: https://github.com/apache/arrow-datafusion/pull/3370#discussion_r963415750
##########
datafusion/physical-expr/src/expressions/negative.rs:
##########
@@ -118,13 +118,11 @@ pub fn negative(
arg: Arc<dyn PhysicalExpr>,
input_schema: &Schema,
) -> Result<Arc<dyn PhysicalExpr>> {
+ // TODO: the data type checker should be done in the logical plan phase
Review Comment:
If datafusion dose this in the preview stage or the logical plan generation
stage, I think we don't need to check the child/input data type for the
physical expr generation.
cc @alamb
Is there user case that user generate the physical plan or physical expr
directly without the logical plan or logical stage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
