liukun4515 commented on code in PR #3370:
URL: https://github.com/apache/arrow-datafusion/pull/3370#discussion_r963715362
##########
datafusion/physical-expr/src/expressions/negative.rs:
##########
@@ -118,13 +118,11 @@ pub fn negative(
arg: Arc<dyn PhysicalExpr>,
input_schema: &Schema,
) -> Result<Arc<dyn PhysicalExpr>> {
+ // TODO: the data type checker should be done in the logical plan phase
Review Comment:
> I am not sure if anyone creates physical Exprs directly without a
logical_plan Expr.
>
> However, I agree with this approach to throw an error if the physical
types don't line up -- automatic coercion should be done at the logical level
Got it.
If the phy expr can be created directly without the type coercion or type
checker in the logical phase, we need this checker in the creation of physical
expr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
