crepererum commented on code in PR #3386:
URL: https://github.com/apache/arrow-datafusion/pull/3386#discussion_r964801149
##########
datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:
##########
@@ -321,10 +318,13 @@ pub(crate) struct SortPreservingMergeStream {
next_batch_id: usize,
/// min heap for record comparison
- min_heap: BinaryHeap<SortKeyCursor>,
+ max_heap: BinaryHeap<Reverse<SortKeyCursor>>,
Review Comment:
But w/ `Reverse`, it's a "min heap" again, so I think the variable name
should read `min_heap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
