tustvold commented on code in PR #3386:
URL: https://github.com/apache/arrow-datafusion/pull/3386#discussion_r966417637
##########
datafusion/core/src/physical_plan/sorts/sort_preserving_merge.rs:
##########
@@ -320,11 +317,14 @@ pub(crate) struct SortPreservingMergeStream {
/// An id to uniquely identify the input stream batch
next_batch_id: usize,
- /// min heap for record comparison
- min_heap: BinaryHeap<SortKeyCursor>,
+ /// Heap that yields [`SortKeyCursor`] in increasing order
+ heap: BinaryHeap<Reverse<SortKeyCursor>>,
/// target batch size
batch_size: usize,
+
+ /// row converter
+ row_converter: RowConverter,
Review Comment:
The way dictionaries are interned is specifically designed to handle this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
