lidavidm commented on code in PR #14077:
URL: https://github.com/apache/arrow/pull/14077#discussion_r966319406
##########
cpp/examples/arrow/CMakeLists.txt:
##########
@@ -36,10 +36,14 @@ if(ARROW_FLIGHT)
# we'll violate ODR for gRPC symbols
if(ARROW_GRPC_USE_SHARED)
set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_shared)
- # We don't directly use symbols from the reflection library, so
- # ensure the linker still links to it
- set(GRPC_REFLECTION_LINK_LIBS -Wl,--no-as-needed gRPC::grpc++_reflection
- -Wl,--as-needed)
+ if(APPLE)
Review Comment:
Should we branch on APPLE or on Clang? (Does Clang support the option on
other platforms?) e.g.
```
if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID
STREQUAL "Clang")
```
##########
cpp/examples/arrow/CMakeLists.txt:
##########
@@ -36,10 +36,14 @@ if(ARROW_FLIGHT)
# we'll violate ODR for gRPC symbols
if(ARROW_GRPC_USE_SHARED)
set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_shared)
- # We don't directly use symbols from the reflection library, so
- # ensure the linker still links to it
- set(GRPC_REFLECTION_LINK_LIBS -Wl,--no-as-needed gRPC::grpc++_reflection
- -Wl,--as-needed)
+ if(APPLE)
+ set(GRPC_REFLECTION_LINK_LIBS -Wl gRPC::grpc++_reflection)
Review Comment:
Probably no need for the `-Wl` entirely here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
