aucahuasi commented on code in PR #14077:
URL: https://github.com/apache/arrow/pull/14077#discussion_r967274342
##########
cpp/examples/arrow/CMakeLists.txt:
##########
@@ -36,10 +36,14 @@ if(ARROW_FLIGHT)
# we'll violate ODR for gRPC symbols
if(ARROW_GRPC_USE_SHARED)
set(FLIGHT_EXAMPLES_LINK_LIBS arrow_flight_shared)
- # We don't directly use symbols from the reflection library, so
- # ensure the linker still links to it
- set(GRPC_REFLECTION_LINK_LIBS -Wl,--no-as-needed gRPC::grpc++_reflection
- -Wl,--as-needed)
+ if(APPLE)
Review Comment:
It seems it is something with the Apple toolchain, because clang can build
this example on ubuntu. So, I think that branching on APPLE make sense here. I
tested on:
```bash
Ubuntu clang version 14.0.0-1ubuntu1
Ubuntu 22.04.1 LTS
Linux 7122ee4a21c0 5.10.104-linuxkit #1 SMP PREEMPT Thu Mar 17 17:05:54 UTC
2022 aarch64 aarch64 aarch64 GNU/Linux
```
btw docker on macos m1 is kind of slow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
