tustvold commented on code in PR #2686:
URL: https://github.com/apache/arrow-rs/pull/2686#discussion_r966587181
##########
arrow/src/array/array_string.rs:
##########
@@ -164,8 +162,7 @@ impl<OffsetSize: OffsetSizeTrait>
GenericStringArray<OffsetSize> {
.add_buffer(child_data.buffers()[0].slice(child_data.offset()))
.null_bit_buffer(v.data().null_buffer().cloned());
- let array_data = unsafe { builder.build_unchecked() };
- Self::from(array_data)
+ Self::from(builder.build().unwrap())
Review Comment:
There isn't really any other expensive validation that takes place,
ultimately the perfomant API is to use the builder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
