tustvold commented on code in PR #2686:
URL: https://github.com/apache/arrow-rs/pull/2686#discussion_r966587388
##########
arrow/src/array/array_string.rs:
##########
@@ -352,8 +349,7 @@ impl<OffsetSize: OffsetSizeTrait>
From<GenericBinaryArray<OffsetSize>>
{
fn from(v: GenericBinaryArray<OffsetSize>) -> Self {
let builder = v.into_data().into_builder().data_type(Self::DATA_TYPE);
- let data = unsafe { builder.build_unchecked() };
- Self::from(data)
+ Self::from(builder.build().unwrap())
Review Comment:
This is a binary array not a list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
