tustvold commented on code in PR #2693:
URL: https://github.com/apache/arrow-rs/pull/2693#discussion_r966656668
##########
arrow-buffer/src/alloc/mod.rs:
##########
@@ -20,34 +20,31 @@
use std::alloc::{handle_alloc_error, Layout};
use std::fmt::{Debug, Formatter};
-use std::mem::size_of;
use std::panic::RefUnwindSafe;
use std::ptr::NonNull;
use std::sync::Arc;
mod alignment;
-mod types;
pub use alignment::ALIGNMENT;
-pub use types::NativeType;
#[inline]
-unsafe fn null_pointer<T: NativeType>() -> NonNull<T> {
- NonNull::new_unchecked(ALIGNMENT as *mut T)
+unsafe fn null_pointer() -> NonNull<u8> {
Review Comment:
This is technically a breaking change, it appears to relate to early
experiments by @jorgecarleitao r.e. arrow2. It isn't used anywhere, and so I
think can just go. The removal is so that arrow-buffer doesn't depend on
DataType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
