tustvold commented on code in PR #2693:
URL: https://github.com/apache/arrow-rs/pull/2693#discussion_r966658029
##########
arrow/benches/buffer_bit_ops.rs:
##########
@@ -38,15 +38,15 @@ fn create_buffer(size: usize) -> Buffer {
}
fn bench_buffer_and(left: &Buffer, right: &Buffer) {
- criterion::black_box((left & right).unwrap());
+ criterion::black_box(buffer_bin_and(left, 0, right, 0, left.len() * 8));
Review Comment:
This is the other breaking change, I opted to remove the `BitAnd`, etc...
implementations for `Buffer` for two reasons:
* They were very easy to accidentally forget to apply the offset
* They need an error enumeration, and defining an error type in arrow-buffer
solely for this case seemed overkill
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
