igor-suhorukov commented on code in PR #14081:
URL: https://github.com/apache/arrow/pull/14081#discussion_r967244098
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/Constants.java:
##########
@@ -27,5 +27,6 @@ private Constants() {}
public static final String SQL_TABLE_NAME_KEY = "SQL_TABLE_NAME";
public static final String SQL_COLUMN_NAME_KEY = "SQL_COLUMN_NAME";
public static final String SQL_TYPE_KEY = "SQL_TYPE";
+ public static final String COMMENT = "comment";
Review Comment:
I prefer "comment" as it much more easy to don't introduce new names for de
facto interoperability with Apache Spark
https://github.com/apache/spark/blob/e83aedd0f072ce18d5542b61eb40e2df1b83bb50/sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructField.scala#L85
Roundtrip conversion with org.apache.spark.sql.types.StructType/StructField
and huge existing ecosystem around (AWS Glue etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
