igor-suhorukov commented on code in PR #14081:
URL: https://github.com/apache/arrow/pull/14081#discussion_r967245996
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/Constants.java:
##########
@@ -27,5 +27,6 @@ private Constants() {}
public static final String SQL_TABLE_NAME_KEY = "SQL_TABLE_NAME";
public static final String SQL_COLUMN_NAME_KEY = "SQL_COLUMN_NAME";
public static final String SQL_TYPE_KEY = "SQL_TYPE";
+ public static final String COMMENT = "comment";
Review Comment:
>>Also, since the JDBC name for this is REMARKS, should we stay consistent
with that?
No, I not think so as it internal JDBC naming, but Arrow target following
Spark/Hadoop but not JDBC
##########
java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/Constants.java:
##########
@@ -27,5 +27,6 @@ private Constants() {}
public static final String SQL_TABLE_NAME_KEY = "SQL_TABLE_NAME";
public static final String SQL_COLUMN_NAME_KEY = "SQL_COLUMN_NAME";
public static final String SQL_TYPE_KEY = "SQL_TYPE";
+ public static final String COMMENT = "comment";
Review Comment:
>Also, since the JDBC name for this is REMARKS, should we stay consistent
with that?
No, I not think so as it internal JDBC naming, but Arrow target following
Spark/Hadoop but not JDBC
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
