tustvold commented on code in PR #2711:
URL: https://github.com/apache/arrow-rs/pull/2711#discussion_r968665000
##########
arrow-schema/src/schema.rs:
##########
@@ -179,8 +186,7 @@ impl Schema {
/// Returns a vector with references to all fields (including nested
fields)
#[inline]
- #[cfg(feature = "ipc")]
- pub(crate) fn all_fields(&self) -> Vec<&Field> {
+ pub fn all_fields(&self) -> Vec<&Field> {
Review Comment:
This needs to be made public, so that the IPC reader can use it. I don't
think this is a big problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
