tustvold commented on code in PR #2711:
URL: https://github.com/apache/arrow-rs/pull/2711#discussion_r968666356
##########
arrow/src/util/decimal.rs:
##########
@@ -296,6 +293,791 @@ pub(crate) fn singed_cmp_le_bytes(left: &[u8], right:
&[u8]) -> Ordering {
Ordering::Equal
}
+// MAX decimal256 value of little-endian format for each precision.
Review Comment:
These were moved out of datatypes as they didn't really belong there, as
they aren't to do with the schema. I'm not entirely sure they belong here, but
they are pub(crate) so we can always move them later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
