lidavidm commented on code in PR #44:
URL: https://github.com/apache/arrow-nanoarrow/pull/44#discussion_r969559066
##########
src/nanoarrow/schema.c:
##########
@@ -591,7 +591,7 @@ static ArrowErrorCode ArrowSchemaViewParse(struct
ArrowSchemaView* schema_view,
return EINVAL;
}
- schema_view->fixed_size = strtol(format + 2, (char**)format_end_out, 10);
+ schema_view->fixed_size = (int32_t)strtol(format + 2,
(char**)format_end_out, 10);
Review Comment:
They seem to be 32-bit integers in the flatbuffers definitions so I'll keep
it like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
