lidavidm commented on code in PR #44:
URL: https://github.com/apache/arrow-nanoarrow/pull/44#discussion_r969560058
##########
CMakeLists.txt:
##########
@@ -89,6 +89,29 @@ else()
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/src>
$<INSTALL_INTERFACE:include>)
target_include_directories(nanoarrow PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/generated>)
+ if(CMAKE_C_COMPILER_ID STREQUAL "GNU")
+ target_compile_options(
+ nanoarrow
+ PRIVATE
+ -Wall
+ -Werror
+ -Wextra
+ -Wno-type-limits
+ -Wno-unused-parameter
+ -Wpedantic
+ -Wunused-result)
+ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR
+ CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
Review Comment:
Derp, I copy-pasted from Arrow…this should be C indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
