andygrove commented on code in PR #3472:
URL: https://github.com/apache/arrow-datafusion/pull/3472#discussion_r970905814
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -1994,7 +1994,10 @@ mod tests {
.project(vec![col("c1").in_list(list, false)])?
.build()?;
let execution_plan = plan(&logical_plan).await?;
- let expected = "expr: [(InListExpr { expr: Column { name: \"c1\",
index: 0 }, list: [Literal { value: Utf8(\"a\") }, TryCastExpr { expr: Literal
{ value: Int64(1) }, cast_type: Utf8 }, TryCastExpr { expr: Literal { value:
Int64(2) }, cast_type: Utf8 }, TryCastExpr { expr: Literal { value: Int64(3) },
cast_type: Utf8 }, TryCastExpr { expr: Literal { value: Int64(4) }, cast_type:
Utf8 }, TryCastExpr { expr: Literal { value: Int64(5) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(6) }, cast_type: Utf8 }, TryCastExpr
{ expr: Literal { value: Int64(7) }, cast_type: Utf8 }, TryCastExpr { expr:
Literal { value: Int64(8) }, cast_type: Utf8 }, TryCastExpr { expr: Literal {
value: Int64(9) }, cast_type: Utf8 }, TryCastExpr { expr: Literal { value:
Int64(10) }, cast_type: Utf8 }, TryCastExpr { expr: Literal { value: Int64(11)
}, cast_type: Utf8 }, TryCastExpr { expr: Literal { value: Int64(12) },
cast_type: Utf8 }, TryCastExpr { expr: Literal { value: Int64(13) }, cas
t_type: Utf8 }, TryCastExpr { expr: Literal { value: Int64(14) }, cast_type:
Utf8 }, TryCastExpr { expr: Literal { value: Int64(15) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(16) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(17) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(18) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(19) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(20) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(21) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(22) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(23) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(24) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(25) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(26) }, cast_type: Utf8 },
TryCastExpr { expr: Literal { value: Int64(27) }, cast_type: Utf8 },
TryCastExpr { e
xpr: Literal { value: Int64(28) }, cast_type: Utf8 }, TryCastExpr { expr:
Literal { value: Int64(29) }, cast_type: Utf8 }, TryCastExpr { expr: Literal {
value: Int64(30) }, cast_type: Utf8 }], negated: false, set: Some(InSet { set:
";
+ let expected = "expr: [(InListExpr { expr: Column { name: \"c1\",
index: 0 }, list: [Literal { value: Utf8(\"a\") }, Literal { value: Utf8(\"1\")
}, Literal { value: Utf8(\"2\") },";
Review Comment:
Well that is much easier to read :heart:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
