liukun4515 commented on code in PR #3472:
URL: https://github.com/apache/arrow-datafusion/pull/3472#discussion_r971416948
##########
datafusion/core/src/physical_plan/planner.rs:
##########
@@ -1712,12 +1714,12 @@ mod tests {
.limit(3, Some(10))?
.build()?;
- let plan = plan(&logical_plan).await?;
+ let exec_plan = plan(&logical_plan).await?;
// verify that the plan correctly casts u8 to i64
// the cast here is implicit so has CastOptions with safe=true
- let expected = "BinaryExpr { left: Column { name: \"c7\", index: 6 },
op: Lt, right: TryCastExpr { expr: Literal { value: UInt8(5) }, cast_type:
Int64 } }";
- assert!(format!("{:?}", plan).contains(expected));
+ let expected = "BinaryExpr { left: Column { name: \"c7\", index: 2 },
op: Lt, right: Literal { value: Int64(5) } }";
Review Comment:
that optimization was done by @Dandandan in
https://github.com/apache/arrow-datafusion/pull/3444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
