alamb commented on code in PR #3483:
URL: https://github.com/apache/arrow-datafusion/pull/3483#discussion_r972011710
##########
datafusion/physical-expr/src/expressions/binary.rs:
##########
@@ -24,7 +24,7 @@ use std::{any::Any, sync::Arc};
use arrow::array::*;
use arrow::compute::kernels::arithmetic::{
- add, add_scalar, divide, divide_scalar, modulus, modulus_scalar, multiply,
+ add, add_scalar, divide_opt, divide_scalar, modulus, modulus_scalar,
multiply,
Review Comment:
default `divide` kernel changed behavior -- `divide_opt` now has the "NULL
on divide by zero" behavior datafusion expects
##########
datafusion/physical-expr/src/expressions/binary/kernels_arrow.rs:
##########
@@ -372,14 +372,18 @@ pub(crate) fn multiply_decimal_scalar(
Ok(array)
}
-pub(crate) fn divide_decimal(
+pub(crate) fn divide_opt_decimal(
Review Comment:
renamed to be consistent with the arrow rename
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
