alamb commented on code in PR #3483:
URL: https://github.com/apache/arrow-datafusion/pull/3483#discussion_r973299714
##########
dev/update_arrow_deps.py:
##########
@@ -88,8 +88,20 @@ def update_version_cargo_toml(cargo_toml, new_version):
for section in ("dependencies", "dev-dependencies"):
for (dep_name, constraint) in doc.get(section, {}).items():
- if dep_name in ("arrow", "parquet", "arrow-flight") and
constraint.get("version") is not None:
- doc[section][dep_name]["version"] = new_version
+ if dep_name in ("arrow", "parquet", "arrow-flight"):
+ if type(constraint) == tomlkit.items.String:
Review Comment:
This is code I wrote in IOx in
https://github.com/influxdata/influxdb_iox/blob/main/scripts/update_arrow_deps.py
Basically the previous version didn't handle `arrow = "22.0.0"` type toml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
