viirya commented on code in PR #2740:
URL: https://github.com/apache/arrow-rs/pull/2740#discussion_r973555646
##########
arrow/src/compute/kernels/arity.rs:
##########
@@ -297,8 +298,19 @@ where
}
let len = a.len();
- if a.null_count() == 0 && b.null_count() == 0 {
- let values = a.values().iter().zip(b.values()).map(|(l, r)| op(*l,
*r));
Review Comment:
This latest optimization cause a bit trouble on the change from
`PrimitiveArray` to `ArrayAccessor` as function parameter.
I can only add one new trait `ArrayValuesAccessor` to coordinate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
