[GitHub] [arrow-rs] viirya commented on a diff in pull request #2740: Add overflow-checking variants of arithmetic dyn kernels

[GitBox]

viirya commented on code in PR #2740:
URL: https://github.com/apache/arrow-rs/pull/2740#discussion_r973604004


##########
arrow/src/compute/kernels/arity.rs:
##########
@@ -297,8 +298,19 @@ where
     }
     let len = a.len();
 
-    if a.null_count() == 0 && b.null_count() == 0 {
-        let values = a.values().iter().zip(b.values()).map(|(l, r)| op(*l, 
*r));

Review Comment:
   I see. Sounds good to do. So I can get rid of `ArrayValuesAccessor ` which 
is just needed to get `values`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org