emkornfield commented on code in PR #14142: URL: https://github.com/apache/arrow/pull/14142#discussion_r974501113
########## cpp/src/parquet/column_reader.cc: ########## @@ -1005,7 +1005,7 @@ int64_t TypedColumnReaderImpl<DType>::ReadBatchWithDictionary( // Read dictionary indices. *indices_read = ReadDictionaryIndices(indices_to_read, indices); - int64_t total_indices = std::max(num_def_levels, *indices_read); + int64_t total_indices = std::max<int>(num_def_levels, *indices_read); Review Comment: should this be int64_t for the template parameter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
