emkornfield commented on code in PR #14142:
URL: https://github.com/apache/arrow/pull/14142#discussion_r974503407
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1328,6 +1329,156 @@ class TypedRecordReader : public
ColumnReaderImplBase<DType>,
return records_read;
}
+
+ // Skip records that we have in our buffer. This function is only for
+ // non-repeated fields.
+ int64_t SkipRecordsInBufferNonRepeated(int64_t num_records) {
+ ARROW_DCHECK(this->max_rep_level_ == 0);
+ ARROW_DCHECK(this->has_values_to_process());
Review Comment:
The first DCHECK seems self explanitory, I'm not sure I understand the
second one though. Just to validate, do you think DCHECK or a throwing here is
more appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
