[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3534: Add serialization of `ScalarValue::Binary` and `ScalarValue::LargeBinary`, `ScalarValue::Time64`

Mon, 19 Sep 2022 11:16:14 -0700 


alamb commented on code in PR #3534:
URL: https://github.com/apache/arrow-datafusion/pull/3534#discussion_r974542669


##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -796,6 +799,9 @@ enum PrimitiveScalarType{
     TIME_MILLISECOND = 22;
     INTERVAL_YEARMONTH = 23;
     INTERVAL_DAYTIME = 24;
+
+    BINARY = 25;
+    LARGE_BINARY = 26;

Review Comment:
   Interestingly TIME_NANOSECOND already existed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to