alamb commented on code in PR #3534:
URL: https://github.com/apache/arrow-datafusion/pull/3534#discussion_r975206002
##########
datafusion/proto/src/to_proto.rs:
##########
@@ -1098,7 +1098,7 @@ impl TryFrom<&ScalarValue> for protobuf::ScalarValue {
})
}
datafusion::scalar::ScalarValue::TimestampMicrosecond(val, tz) => {
- create_proto_scalar(val, PrimitiveScalarType::TimeMicrosecond,
|s| {
Review Comment:
these names were super confusing as the protobuf definition used `Time` and
`DataType` and `ScalarValue` used `Timestamp`.
Making it more confusing is that `ScalarValue::Time64` is not a timestamp
(it is the time of day!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
